fix(sdk-metrics): InMemoryMetricExporter clear metrics after shutdown
#5214
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5214 +/- ##
==========================================
- Coverage 94.60% 94.59% -0.02%
==========================================
Files 315 315
Lines 8012 8013 +1
Branches 1617 1617
==========================================
Hits 7580 7580
- Misses 432 433 +1
|
paper2
force-pushed
the
develop/clear-in-memoery-metrics-exporter-data-post-shutdown
branch
3 times, most recently
from
875ec47
to
5ba87cd
Compare
paper2
changed the title
paper2
force-pushed
the
develop/clear-in-memoery-metrics-exporter-data-post-shutdown
branch
from
5ba87cd
to
2bf3748
Compare
david-luna
approved these changes
Nov 29, 2024
david-luna
reviewed
Nov 29, 2024
CHANGELOG.md
Outdated
| @@ -12,6 +12,7 @@ For semantic convention package changes, see the [semconv CHANGELOG](packages/se | |||
| ### :boom: Breaking Change | |||
|
|
|||
| * feat(sdk-metrics): Add support for aggregation cardinality limit with a default limit of 2000. This limit can be customized via views [#5182](https://github.com/open-telemetry/opentelemetry-js/pull/5128) | |||
| * fix(InMemoryMetricExporter) clear metrics after shutdown to align with other exporters [#5131](https://github.com/open-telemetry/opentelemetry-js/issues/5131) @paper2 | |||
There was a problem hiding this comment.
I wonder if this should be considered breaking. The API remains intact and it's a fix to have the proper behaviour 🤔
There was a problem hiding this comment.
Thanks for your review!! I try to move it 🚀 (Enhancement).
david-luna
changed the title
InMemoryMetricExporter clear metrics after shutdown
|
@paper2 I've updated the title to follow the guidelines :) |
paper2
force-pushed
the
develop/clear-in-memoery-metrics-exporter-data-post-shutdown
branch
from
2bf3748
to
bbd9b5f
Compare
paper2
force-pushed
the
develop/clear-in-memoery-metrics-exporter-data-post-shutdown
branch
from
bbd9b5f
to
b3c14d5
Compare
david-luna
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #5131
Short description of the changes
Type of change
The InMemoryExporter does not directly affect the functionality of this library, but I consider it a minor specification change for the library. In fact, I encountered this issue while using InMemoryExporter in another project. If there are tests that retrieve metrics after shutdown, they will fail.
How Has This Been Tested?
Checklist: